[Disk Manager] Add context handling in collectListerMetricsTask #4633
+22
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkuradobery
requested review from
Copilot and
gy2411
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Run method in collectListerMetricsTask to improve context cancellation handling by using a select statement instead of a simple for range loop over the ticker channel.
Key changes:
- Added explicit context cancellation handling via
selectstatement withctx.Done()case - Restructured the ticker loop to allow graceful shutdown when context is cancelled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
BarkovBG
previously approved these changes
Nov 10, 2025
SvartMetal
reviewed
Nov 10, 2025
Contributor
SvartMetal
approved these changes
Nov 10, 2025
BarkovBG
approved these changes
Nov 10, 2025
BarkovBG
deleted the
users/jkuradobery/make-collect-lister-metrics-more-cancellable
branch
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.